I'm a recently graduated software engineer at a small startup with 7 staff, of whom 3 work on software - the CTO, myself, and another software engineer. I've been there nearly a year, and the other software engineer has been there a couple of months. I'm nobody's boss, but I have some influence because I represent 1/3 of the entire software team and I have more knowledge of coding standards than either of the other two developers due to previous experience at a different company.
At my recommendation we've recently started doing code reviews for code that is getting pushed to a few core libraries which other projects depend on. The other team members are happy to have their code reviewed and to review code (unlike these questions) - my problem is simply that when either of them reviews my code, they invariably look it over for a minute or two, occasionally make a couple of comments, and then approve it without suggesting any changes.
Not once since introducing code reviews have I had to make any changes prior to approval. I know they're missing things, because I've caught bugs myself in things I've committed, but I can't point out flaws that I haven't noticed.
What specific things can I do to encourage the rest of my team to be more effective during code review?
I've tried the following:
- Simply asking them to be careful and critical
- Pointing out after each overly quick review that it was very quick
- Drawing attention to things that I'm uncertain about when submitting code for review
- Asking questions about the code I'm submitting to force them to study it
- Reviewing their code according to the standards which I would expect them to review mine