Timeline for Colleague reviews a same pull request several times instead of once
Current License: CC BY-SA 4.0
7 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Aug 17 at 2:30 | comment | added | O. R. Mapper | ... existing piece of code. IOW, the senior iteratively gets a better idea of what the code should look like, just as they presumably iteratively refine their own code. In that sense, I second your suggestion to look for "areas where things he has raised previously might be applicable", but suggest to extend this to trying to understand and adopt the senior's pattern of looking at and thinking about the code, with the goal of producing code that not just solves the task at hand, but is well-geared e.g. for future maintenance and extension. | |
| Aug 17 at 2:26 | comment | added | O. R. Mapper | "it seems like your Senior is trying to teach you a lesson" - I suspect even beyond this, the OP may be observing their senior actively doing more than "the bare minimum to get onto the next task". E.g. the senior may have added a comment to improve stability of the code and they thought it a reasonable change. But after the change was done - or maybe even just after reading another piece of code - the senior would not just be content with having "fixed" the OPs contribution and move on, they'd come back to the OP's PR and suggest a further improvement, e.g. to increase reuse of some ... | |
| Aug 16 at 21:36 | comment | added | bytepusher | Great answer. Just wanted to add that part of the quality of the code is also code style. Many problems can be solved fine in more than one way. Best stick to the style that exists already. I've tutored a number of developers, and this is something that takes most people a while to grok. | |
| Aug 15 at 21:17 | comment | added | TheDemonLord | @LoremIpsum - if you keep making the same mistakes over and over and not demonstrating ownership of your work, then yes - I would say it is. | |
| Aug 15 at 18:33 | comment | added | LoremIpsum | I think this answer is great (and I had previously accepted it) but it kinda misses the point. I never claimed something about the quality of my code, I even said that his reviews are constructive, even when nitpicking. But is it then justified to "teach me a lesson" by going over piecewise over the proposed change, making a single step process a multi-step one? | |
| Aug 14 at 20:06 | vote | accept | LoremIpsum | ||
| Aug 15 at 6:45 | |||||
| Aug 14 at 19:52 | history | answered | TheDemonLord | CC BY-SA 4.0 |