I'm a new employee at a software company, and saw an email sent to an coworker from a system owner, but with the whole dev team CC'd, and it got me a bit worried about the environment. I'm recently out of college so this is my first job so...is this normal in tech companies?
Sent to Rick and Cc'd dev team mail list:
I ran valgrind on the SpaceShip proj, and I think I found a memory leak in some of the platform code. I believe I found the source and the issue can be fixed with the below diff:
--- a/spaceship/DoBattle.cpp +++ b/spaceship/DoBattle.cpp vector<part> parts = getSpaceShipParts(); +shared_ptr<SpaceShip> p = new SpaceShip(parts); -SpaceShip * p = new SpaceShip(parts); engageInBattle(p, enemy);
I re-ran valgrind with the change, and it seems to fix the problem!
A pretty reasonable email I thought, which was answered with:
Thanks, but in the future please just provide the information about how to reproduce a problem, not a suggested fix. I don't read suggested fixes, because they predispose me to a particular idea of what the real problem is and what the fix should be. I'm better off going in fresh and deciding for myself.
In cases where I accidentally read a diff before realizing what it is, I purposely spend at least several days trying to forget so I can go into it fresh. So giving me a diff just makes it more likely I won't even look at the problem for some time.