I am a Junior at my work. Often recently the Senior who sits behind me has taken to coming over to me and making suggestions about changing and reordering my code... Initially I took him at face value and tried to implement to his suggestions, but I have found the suggestions he makes usually either totally break or at best degrade the quality of my code.
I get on well with the Senior on a personal level and sometimes he does achieve valuable things with his own code -- in some ways strangely because he often seems to be telling me to implement practices he avoids in his own code. The conversations around this are increasingly taking up my time to the point of almost getting in the way of my producing to task.
Today we got to a point where after my rebuffing numerous suggestions on the grounds of them being unworkable or involving a focus on polishing minutia at the expense of MVP we got to the point of him saying "yes, but if you finish this yourself what will other people have to do?".
There is far more to do than could possibly be done and always lots to be getting on with, and I even suggested he could contribute to the task if he wanted -- something he didn't seem very keen on.
As I said I get on well with him in general, but I am keen to resolve this issue before it escalates. How best to deal?