I have recently joined a startup in software engineering, and my tasks consist of writing code that gets merged into the master branch. Before the code is accepted, it is reviewed by my manager, who is also a founder of the company. One piece of code that I wrote addressed quality issues in a component that the manager wrote some time ago. The component is tailored to a specific scenario and needs manual tuning to work satisfactorily. After much work on the issue, I changed some of the functionality, and I documented many of the "hidden" assumptions in the new and existing code that would help the next person that would have to deal with the manual tuning process if the scenario changes. After the review, the code functionality was unchanged. However, the documentation about the assumptions was removed without explanation by the manager. I am wondering how to proceed in this situation.
- One interpretation is that the manager does not want the code to "look" bad. Then it would not make much sense to ask why the documentation was removed; since then, I would get no answer or some pretext answer, and I would only upset my manager. The lesson learned is that the code documentation should not be too detailed on the deficiencies.
- He removed it by mistake. By asking about it, he would appreciate my diligence.
- There is some company coding policy I have misunderstood.
- The manager is embarrassed that I pointed out flaws in the code he wrote but values the improvement nonetheless.
- The manager thought the code documentation added no useful information or that the information should be documented elsewhere.
I'm unfortunately more inclined to (1), but I am wondering if there are any other aspects I am missing.
Question: In any case, is there anything for me to gain by asking the manager why the documentation was removed?
Edits: more interpretation thanks to comments!