Hot answers tagged

254

Not to be rude, but if If you gave me any FizzBuzz-like question, I would expect to fail it. Then you can't code at all. The only thing fizzbuzz do is weed out candidates who cannot code. If you want reasonably respected coding qualification The only thing you can do is get mileage. And lots of it. Implement small webapps, small prototypes, write ...


238

There's a couple of things that I've found help a lot with the reception of code reviews: Don't say "you", or variations on it ("your code", etc). You're not ripping apart "his" code or "his" solution. It's our code, or this solution, and we need to do things to it. As soon as someone starts talking about "your" code, a lot of people's natural reaction is ...


221

I have asked "could you walk me through some of your best and worst code for a few minutes?" the last two times I went job hunting, usually at the end where people ask "do you have any questions for us?" Thus far, this has universally been received as positive. Not all companies may be willing/able to do this – much depends on company culture, size, industry,...


200

Unless Clint finds any major, “do not deploy”, bugs, I would simply thank him for his feedback and explain to him how you intend to address the points he raises (if valid) in future releases. If he has a problem with this, then you have the opportunity to explain why it would be better for him to give feedback earlier. Ultimately, it is his problem he is ...


136

How would you deal with such situation ? After nicely comforting him, which you have already done, it's time to firmly tell them to deal with it. It is not an individual's code, but the company's. As a manager, you need the code to be as maintainable as possible by your team and new additions you make to the team in the future. "code formatting is ...


132

Honestly, my reaction would be the following: Bob, I appreciate the feedback, but as a team we've decided that we're using Black as our mandatory code formatting tool, and that decision is final. I understand it's not your personal preference, but I'm afraid that you're going to need to learn to work with it. But if I wanted to engage in a discussion? ...


121

Should I raise this with my team lead? No. The most junior member who has only a couple of years experience should not be complaining to team leads about the code quality of the most senior member. Let the team lead deal with it - there is absolutely no way that you would be telling them something they don't already know. The reasons that they tolerate it ...


116

While the other answers are good, you have mentioned something new and relevant in a comment, which might be causing the specific behaviour from your teammates in your case. You said: I'm also the most senior dev in the team That could be important here. In that case, I can easily imagine that you are treated with extra deference / respect, and a mixture ...


115

Speaking as somebody who has been a developer and a team leader in in this industry for a long time now... I don't care about your qualifications. At all. When I have your CV in front of me I care about your attention to detail with the CV (spelling, layout, font consistency), and I care about demonstrable relevant experience. By demonstrable relevant ...


102

What would you make of this; do you think my language was unprofessional? Yes. Your comment crossed the line from correcting (which typically relies on specific and concrete comments) to insulting ("this is terrible and if we keep it up we're doomed"). It doesn't matter how much experience you have. It doesn't matter if the code is complete garbage. ...


102

All code should be peer reviewed (but I've worked in a lot of places where that never happened). How clean is clean? There should be coding standards and guidelines; ask for them. As to how "picky" you should be; that depends on the code being reviewed. Some people like having blank lines pointed out to them, and spacing. Others prefer you spot potential ...


97

So your senior and you disagree on what the coding conventions means and which way is more readable. The way to resolve this is to clarify your understanding so everyone is one the same page. Therefore, I'd have reacted as follows: S: Why are you doing this? You are changing my code. We are a team ... J: I tried to make it adhere to the coding convention. ...


96

A few points in addition to the other answers: Accept that, as a junior, you don't know everything :-)  There may be reasons for the style of code that you are unaware of, such as: Avoiding unnecessary changes to working code (keeping diffs manageable, avoiding introducing unnecessary bugs, &c). Keeping related code so it can be seen together.  (No ...


88

Am I justified in feeling like I'm being exploited by the other researcher to write this code or am I being selfish? No, you aren't being "exploited" - if I understand you correctly this code would benefit you and your supervisor as well. That it will also benefit others is good thing. Can I protect my code from others using it without creating tension/...


73

One thing I did when I became lead was to create a best practices and coding standards document. I included everything right down to naming conventions for variables, objects, and procedures. Code reviews are useless unless, and until, a well documented set of best practices and procedures have been established. THIS use const instead of var ...


72

I think you're taking this way too personally. I used to get pretty annoyed with a "thumbs down" of my PR (Pull Request / Peer review). but it's not meant to be that way. It just means the code is not yet ready to merge. How do you respect your boss when he asks you to write the code in his fashion Your boss has been tasked to provide a solution - s/...


72

You’re ashamed because you’re growing as a software engineer? The more you learn, the worse your old code looks... just comes with the territory. Keep looking forward, that “horrible” code you’re referring to helped you get to where you are today. You’ve learned, and that’s nothing to be ashamed of. Worrying about those who are judging you is rarely a ...


69

I would try to convince him of the positive effects of uniform code formatting. Git diffs become much easier to digest when commit n and commit n+1 have the same formatting. Maintainability becomes easier, assuming the formatter enforces good practices. In the end, corporate software development is a team sport. If your code formatter allows defining rules,...


66

Either a code review is required for the release, or it is not required. If it is required, then the reviewer must be responsible for reviewing this in time. You must have the power to go to his desk and say "drop everything else and do this review, or we can't make the release date". And you must have the power to say "sorry, we couldn't release in time ...


60

Manager asked me to reconsider my resignation and he sounded quite convincing, should I listen to him? Unless he presented a written offer, that included the increased salary you should not be convinced of anything other than "business as usual". Any manager that has the desire and means to give you what he has "promised" would have already done so. ...


59

Let it go. You are trying to compromise among 3 or 4 priorities: your preferences, the Code Conventions, the preferences of the senior dev whose code you changed, and the team's ability to make sense of the code. According to the senior dev, his coding style makes sense to the team. So priorities 3 and 4 can be combined. Now it's between you, the code ...


51

How would you deal with such situation ? I would try to understand the recalcitrant developers point of view. They may have good points to make that I'm ignoring. We implemented auto formatting on our codebase a few years ago and it caused no end of problems, partially due to the way it was introduced, but mostly due to the way it impacted our workflow. It ...


49

This: Due to my programming time at university, in a roundabout way, I've already learned. Does not align at all with this: If you gave me any FizzBuzz-like question, I would expect to fail it. Do you know where FizzBuzz came from? It is meant as a quick programming problem to screen out those who cannot code at all so that the interviewer doesn't ...


48

It is the nadir of unprofessionalism in Information Technology to be derisive of another's code in such a fashion and it goes beyond the derision to the way you made the point. It was done publicly, which is why you were pulled aside (virtually) It disrupts a team. It breeds resentment. Coders, like artists take critique VERY personally. It was a massively ...


47

The short answer is: No It's the job of the person executing the merge to ensure that the process has been followed. You did your job, now they have to do theirs. You could follow up with them and ask why there are no comments or feedback on your pull requests if you feel there should be. This is a cultural question - how does your office work normally? ...


42

I am an employer of several developers. Screening Tests: We ask candidates to answer a 20-30 minute multiple choice test which attempts to screen candidates who would never succeed in a coding interview. This is in the interest of the candiate as well as the employer, as it reduces the amount of time wasted by all parties. If your prospective employer ...


41

In all of my years of programming, I've never had a request to write something that could be actually used by their business. I've had mock debugging tasks, I've been asked to write a form that will do certain things and other things like that. My guiding rule is to follow my gut. You've had a sanity check here and there are several saying that this is ...


36

As this is the first time you are "writing code for something beyond classwork" I think it is important to learn some of the basic principles of what it means to write software for money, as I think once you understand these, the answer to your questions flow pretty naturally. First principle: when someone pays you to write code, it implies two things: ...


Only top voted, non community-wiki answers of a minimum length are eligible