Hot answers tagged

279

But something I need to do. But what? Provide your feedback in a "constructive way", and be done about it. Not your place to make decisions. Mention something along the lines of "It was good to get a chance to evaluate the product X. As I see it: - Pros: 1, 2, 3 - Cons: 1, 2, 3, 4, 5, 6, 7, 8, 9, ...... As it is evident from the analysis ...


234

There's a couple of things that I've found help a lot with the reception of code reviews: Don't say "you", or variations on it ("your code", etc). You're not ripping apart "his" code or "his" solution. It's our code, or this solution, and we need to do things to it. As soon as someone starts talking about "your" code, a lot of people's natural reaction is ...


81

How should I deal with this situation? Just telling everyone that I haven't written them or be quiet? When asked, just indicate that you didn't write them. Maybe you could consider stopping publicly venting about the company problems until after you have left for a new job.


67

If you believe that a coworker is operating in cronyistic manner and playing fast and loose with company funds, yes, that is something you should raise with your manager. Saying the software is "crap" is not likely to get you much traction. You must quantify how it is substandard, and how the business will not get the appropriate value for money. Just as ...


30

You seem to be a part of a team that is more experienced than you yourself are. The fact that these people have been working together for longer, and perhaps feel that their work is higher quality may lead to the attitude you're experiencing today. I have no way to tell whether you've done anything to make the rest of the team feel like their behavior is ...


27

I have been in such a situation a lot of times. And the first thing I usually say is: sorry.... Yes, right... because if he did not get easiest things right, like naming conventions, that means that you (or whoever was responsible for him) did not make a good job in introducing them to him... So apologize for not having given him enough information to do a ...


22

As you didn't write them, unless you are asked by someone specifically the last thing you do is start a conversation about it and claim "it wasn't me" that instantly makes everyone think it was you. Don't talk about them and don't mention them again. As you are looking for a new job, I assume by 'backfire' you mean, you are worried people will believe it ...


22

they address the very specific problems I have with the company THEY - multiple comments SPECIFIC - So an inside knowledge is presented I HAVE - and not only you. You need to realize, "If I didn't write them then it had to be someone else" ergo other people in company have same/similar problems. So if asked and ONLY if asked directly say I'm not the ...


22

First of all, don't insist on a particular way of taking feedback and learning from it. In particular, not taking notes on paper is not necessarily a sign that the junior does not get anything/enough out of the code review. For most "programming style" code reviews I've never taken paper notes, because I rather focus on talking about the code and thinking ...


20

IMO you have misunderstood the technical process and this is causing a business problem. I will address both, because they are interrelated. Technical misunderstanding: A code review is not a superior checking on the work of an inferior. A code review is a second (or more) pair of eyes looking at what was done, what was not done, how it was done, and how ...


19

I'm pretty sure this retreads ground from previous questions, but having been in the shoes of both sides, I'd give the senior developer some presumption of clue, and work with them to convert their complaints into constructive actionable improvement recommendations, and have everyone follow through on those process improvements, and monitor with each party ...


18

(Good) management is influenced by logic, not name-calling. Reading your OP, you have mentioned that you think this software is crap, but you didn't say how or why. If I was a manager and I read your OP, I would think you were just a troublemaker, and you would lose face with me. If this is how you wrote the email to management, then it's a good thing you ...


17

This is an easy one. You will need a job anyway in 7 months and your employer doesn't mind if you leave earlier. There is no renewing this contract. There is no benefit for you if you delay. Do what you can to get better at your job and at the same time look for another one.


16

Kindly help me to prepare for this situation I offer the standard advice regarding code reviews. You are not your code. Learn not to be offended or aggressive during code reviews. Make sure to focus on the code, not the people. Don't be so defensive. Remember that, even though you have been working for 10 years and know all the latest technology, the ...


15

But something I need to do. But what? First thing constructive to do is to check your motivations carefully, why do you need to do something? Why do you want to engage in a dispute that you think you will lose. If you're asked to analyse a tool, do so, give the pro's and cons without bias. Don't create problems without complete analysis or reason.


15

The most important thing to keep in mind is that code quality is dependent on the criteria you are measuring against. In a vacuum, essentially every piece of code can be improved. If you have no standard to measure against, you can run the risk of either falling into a bottomless pit of optimization, or at best ending up disagreeing with team members over ...


13

Ask for examples of better logic, and a discussion about why it is better. If your logic actually is poor, it is probably because you don't fully understand the problem to be solved. And if you actually have ten years experience and you don't fully understand the problem to be solved, it is probably because the specification is incomplete or wrong. This ...


13

When someone messes up badly at the beginner level, it just means they need to grasp the basics. I don't analyse their mistakes and try and teach that way. I already solved those, and there was a probably a bit of cursing going on so old news. I just run through the basics in detail. By that I mean the conventions, procedures, etc. Importantly I teach him ...


12

First, there is no such thing as anonymity. The more information you divulge in a review the easier it is to identify the exact person who posted it. Second, you have to weigh the consequences of your speech. Sure, you can write whatever you want in a review but there may be negative consequences for doing so. Obviously you are now running into some of ...


12

Something's really very wrong here - especially if you've mentioned this to your manager and still nothing is being done. You shouldn't have a PR still awaiting review from November while others get approved the same day. There are reasons I can think of that might be why other members of your team are reluctant to review them, but they're just speculation, ...


10

You should never quit a job unless you have something lined up. And you should never let your employer know that you're leaving, or searching for a new job. There's too much risk and not enough benefit. Otherwise you risk having no income, and being reliant on savings (if you have any) and potentially being laid off before you decide to quit. In addition, ...


10

Rewrite the letter you were going to send your boss. Don't assume bad intentions from your coworker. Be polite. Be specific. Drop the word "crap". Give your honest but detailed evaluation and be able to back up every point you raise, and ideally put an example of each point in the letter. Boss, I've reviewed the code being offered and I view it as sub-...


10

There's a golden rule of programming: Code is meant to be read by humans, and only incidentally executed by computers. If you can't read the code? Then it's bad code. "But maybe it's because I don't have the best memory, and I have to try to..." No. Stop. As much as I love Internal Locus of Control, and finding ways to fix issues instead of blaming ...


9

Have you considered a job change? Seriously feedback like code-reviews is vital to YOUR career growth. Some companies take code reviews seriously, some don't. Even if you could manipulate this situation to force the senior-dev to review your code, he's not going to review it to the degree that you want since he feels this is a waste of time. Rather than ...


9

Major issues in the logic, lack of knowledge for how to trace back an issue to the root cause, and very obscure naming conventions (this was very problematic due to the nature of the project). I would start with the easiest first. "Naming conventions" Your company probably has a guide. The book Code Complete 2 can be a pretty good guide too. It ...


9

The situation isn't bad, it is good. Once you get your head around this fact, the talk will be much easier. The project was finished on time. You have the time and expertise to further improve the project that already does what it is supposed to do. It is perfectly natural in software engineering to have architectures that are not optimal and to improve ...


8

You were right to give negative feedback as long as that is honestly what you observed. I cannot imagine there is an unwritten rule that negative feedback should not be given. If there is such a rule, it should be violated whenever negative feedback is earned. To me, there is an even bigger unwritten rule - when responses are stated to be anonymous, then ...


8

Rather than challenge the reviewer I would write. What rules(s) did I violate? What Framework did I use? I used no Framework as I understand the definition. Go at it with the presentation if you just want to learn.


8

The first question to ask is, have you spoken to your boss about this? Did your boss acknowledge that this was an issue or a mistake? The second question is, when you say "made accessible", do you mean it was put in front of everyone or was it tucked away on a file share somewhere? Was anyone else's review also made accessible? The third question is, if ...


Only top voted, non community-wiki answers of a minimum length are eligible