Timeline for Code readability, conventions and should I let go
Current License: CC BY-SA 3.0
8 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Nov 15, 2017 at 7:07 | comment | added | GrandOpener | Anyone who says "this is my code ... don't touch my code" immediately loses almost all credibility with respect to communication skills and working as a team. Even if he's right about his way being better, this is just about the worst possible way to express that. Obviously I don't know all the details, and maybe he was just having a bad day, but an interaction that toxic with a senior dev is sufficient motivation to start polishing your resume in many scenarios. | |
| Nov 14, 2017 at 22:44 | vote | accept | Stankar0x | ||
| Nov 13, 2017 at 13:20 | comment | added | Flater | [..] following an established guideline that is objectively defined. If there is such an established guideline, he should be referring to the guideline as opposed to being offended by OP's actions, making exaggerated "100 years of maintainability" claims, threatening to remove OP's access to the code, or arrogantly claiming that his code is (unequivocally) not to be touched. If the quote from the lead dev is in any way accurate, there is a massive issue with the lead dev's overconfidence and proactive prevention of anything that highlights an honest mistake (or imperfect solution) by him. | |
| Nov 13, 2017 at 13:18 | comment | added | Flater | While I predominantly agree with the answer, I don't agree with the justification of "According to the senior dev, his coding style makes sense to the team." (1) Everyone's code makes sense to themselves. You should check the opinions of others. (2) A senior can enforce coding standards based on being a senior, somewhat regardless of the standard he's setting. The fact that the lead dev engages OP on a personal level ("why are you doing this?" as opposed to "the coding standard is [such and such]") suggests that the lead dev is calling the shots, rather than [..] | |
| Nov 13, 2017 at 9:43 | comment | added | Matthieu M. | @DavidHammen: Most toxic coworker ever. Reminds me of a senior colleague who was dead set against code reviews because he didn't want anyone to review his code... | |
| Nov 13, 2017 at 1:08 | comment | added | David Hammen | Re According to the senior dev, his coding style makes sense to the team. I suspect that that is not the case. It is "his code" that this newbie had the gall to touch. I suspect nobody touches his code because (a) it's utterly unreadable but magically appears to work and (b) the guy is so touchy about "his code" that anyone who dares touch it gets a lecture. | |
| Nov 12, 2017 at 18:33 | comment | added | Bernhard Barker | Based on the coworker's quote, between the threats, bullying and exaggeration, I very much doubt that they're the type of person to be able to accurately speak for others by actually considering the opinion of anyone else. | |
| Nov 12, 2017 at 15:12 | history | answered | A.S | CC BY-SA 3.0 |