Timeline for How to handle requests to change code written by my superior
Current License: CC BY-SA 4.0
5 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Apr 26, 2021 at 5:52 | comment | added | HawkingRadiation | @MatthewRead: The part that the code hasn't been reviewed before was added later to the question after my answer. spuck's suggestions is a nice way to work with that fact. Thanks. | |
| Apr 23, 2021 at 22:49 | comment | added | spuck | Maybe the first commit message needed to be "Initial commit; code is as inherited". That way the OP can claim "the code is this way because it was like that when I got here." :) All kidding aside, this answer is correct: the code review should be limited to changes, not to a philosophical discussion of every other thing that might be improved. That's a different (or several) ticket... | |
| Apr 22, 2021 at 22:52 | comment | added | Matthew Read | Earlier in the question, the OP says that the original code had not been reviewed yet, so that is included in the immediate changes they've put forward for this review. So the teammates are doing the right thing here, and not just looking elsewhere for issues. | |
| Apr 22, 2021 at 12:49 | review | First posts | |||
| Apr 22, 2021 at 14:18 | |||||
| Apr 22, 2021 at 12:45 | history | answered | HawkingRadiation | CC BY-SA 4.0 |