Skip to main content
2 events
when toggle format what by license comment
Sep 24, 2022 at 20:11 comment added Llewellyn I don't necessarily agree that constructive criticism in a review (even if it means "rejecting" the PR) requires talking to the person. That's an expected outcome of a PR, and the comments should only be about the code and never attack the developer in the first place. However, once there's some kind of disagreement or misunderstanding, a face-to-face talk can make a ton of difference.
Sep 23, 2022 at 7:57 history answered rotisiv CC BY-SA 4.0