Timeline for Colleague reviews a same pull request several times instead of once
Current License: CC BY-SA 4.0
16 events
when toggle format | what | by | license | comment | |
---|---|---|---|---|---|
Aug 18 at 5:09 | answer | added | O. R. Mapper | timeline score: 0 | |
Aug 16 at 23:30 | answer | added | Jeremy Hunt | timeline score: -1 | |
Aug 15 at 19:06 | answer | added | setbitzero | timeline score: 21 | |
Aug 15 at 18:27 | history | became hot network question | |||
Aug 15 at 16:00 | answer | added | puck | timeline score: 4 | |
Aug 15 at 12:28 | comment | added | user145885 | Tangential: You're not currently a member of the SE Code Review community. Suggest perusing some of those Q&As (filtering for your language interests) to see what goes on elsewhere. Some Q's remain unaddressed, and some have multiple "answers/reviews". I'm not suggesting you will learn anything there except an appreciation for how 'many eyes' see 'many problems' and 'many ways' to improve code. Nothing is ever "perfected and finished". Welcome to life! | |
Aug 15 at 11:13 | comment | added | Mark Rotteveel | Are you sure that your colleague stops reviewing after their first comment, wait for you to fix the issue and the continue their review with the next piece? That wouldn't be normal IMHO. Or are they reviewing iteratively? When you re-review code, you might see different problems than the first review, because the glaring problems are now gone (because of your previous review comments). This is absolutely normal in my opinion. | |
Aug 15 at 9:34 | answer | added | Zdeněk Jelínek | timeline score: 4 | |
Aug 15 at 7:36 | comment | added | Fiora the Ferret | If it's the more nitpicky comments that are annoying you, have you considered proposing a linter / autoformatter for everyone that gets initiated by a pre-commit hook? That would let you all focus more on the more substantial issues. | |
Aug 15 at 6:08 | answer | added | nvoigt♦ | timeline score: 7 | |
Aug 14 at 20:06 | vote | accept | LoremIpsum | ||
Aug 15 at 6:45 | |||||
Aug 14 at 20:02 | review | Close votes | |||
Aug 20 at 3:03 | |||||
Aug 14 at 19:52 | answer | added | TheDemonLord | timeline score: 18 | |
Aug 14 at 19:27 | answer | added | user145885 | timeline score: 8 | |
Aug 14 at 19:25 | answer | added | keshlam | timeline score: 5 | |
Aug 14 at 19:01 | history | asked | LoremIpsum | CC BY-SA 4.0 |