Questions tagged [code]

Questions relating to computer coding practices.

Filter by
Sorted by
Tagged with
3
votes
3answers
501 views

Colleague prefers to roll their own solutions that are completely unnecessary

How do I help a coworker with more years of experience write cleaner code? Let's call them Dario. What are some tips on how to gradually introduce clean code concepts while still being respectful and ...
1
vote
4answers
572 views

Who to go to about a code review?

I am an apprentice at a large-ish company (500-600 employees). It is an engineering firm. I have written a web app which was not requested by anyone to start with but when I demonstrated the potential ...
77
votes
14answers
12k views

Is it a problem that pull requests are approved without any comments

I've recently joined a new company within this pretty small team. I'm running into this issue where my coworkers approve my pull request a few seconds after I ask them to review it. There never are ...
119
votes
25answers
23k views

Team member is vehemently against code formatting

I am the manager of a small team of developers (5 engineers, including me). A few months ago, on the suggestion of another colleague we introduced mandatory code formatting in the code base, for our ...
5
votes
5answers
529 views

Code Ownership Vs Responsibility&Credit

I'm having mixed feelings about a situation in my workplace. I’m getting the impression that a colleague wants to claim my work as his, but I’m also suspecting it might be unfair of me to think so. ...
101
votes
18answers
29k views

Can I criticise the more senior developers around me for not writing clean code?

I am a junior developer. Although I already programmed in different languages for the last 5 years I still have a hard time debugging more complex issues. On the other hand I like clean code and try ...
10
votes
5answers
1k views

Professionalism: protecting code quality

TL;DR: Questions under the text I am a software developer at the R&D center. Due to my seniority, I am oftentimes asked to review time/scope critical changes to our code-base. Due to the hectic ...
8
votes
3answers
1k views

I developed code and “donated” it my workplace to speed things up. Now do they own that code? [closed]

I work at a small startup as a full stack developer. We previously used PHP to develop all of our applications and I told my boss we should eventually move to C# which he agreed. Over the coming ...
2
votes
3answers
463 views

Technical interview coding and bad code sharing web applications [closed]

During tech interviews, some companies open up a web application like "codeshare.io" or coderpad.io and they ask an algorithm question etc. I normally use Intellij Idea whenever I code and I'm not ...
5
votes
5answers
746 views

How can I identify coding skills without any IT background? [closed]

We are a small company and looking for a full-stack developer (NodeJS) with focus on Node and React. Since we all don´t have an IT background it´s difficult to really check on the quality of the ...
-10
votes
6answers
889 views

How to deal with a software developer who doesn't seem to understand that he's just a coder?

As a manager for a software development team, how do I deal with developers who don't seem to understand what their job description is? In particular, I am currently dealing with a junior developer ...
7
votes
6answers
1k views

How to not sound passive aggressive in code reviews?

As a young guy in my first programming job, I can't figure out how to avoid sounding passive aggressive when providing code review comments or when responding to such comments in my own code. It ...
5
votes
1answer
496 views

How should I approach my boss about more code-reviews?

I work as a trainee in a large IT-company for a little more than one year now. After a few weeks of crash course training, I was assigned to update the front-end for one of our departments. It ...
1
vote
3answers
547 views

Code sample for embedded software developer application? [closed]

Unexpectedly, I've the chance for a dream job as an embedded software developer. The application requires a code sample to be included with the CV. I have a very good experience in C. But ...
72
votes
10answers
21k views

Coworker reviewing code too late in process

Over the summer I changed jobs from a big company as a senior engineer to a way smaller company as a principal engineer. Now I oversee about 20 jr-to-mid-level engineers working on 3 different ...
3
votes
2answers
397 views

How to pass interviews if you never contributed to an open source project? [duplicate]

I am getting stuck already in few interviews when the companies ask me to show them my source code. During 10 years of career all "my" source code is private, sealed by many NDAs source code that is ...
9
votes
4answers
1k views

Co-worker letting coding standards drop again after large refactor - how to enforce better practices?

After we spent 4 years cleaning up the code and it is working OK again, my colleague started to get messy again. Ignoring Reviews with the usual phrase "I have more important tasks to do atm" means ...
5
votes
2answers
501 views

How can I encourage my coworkers to produce better quality code? [closed]

I'm a team lead for a small group of programmers. We share several projects with other teams. Lately the quality of two other teams' code has deteriorated to the point where it is slowing us down and ...
8
votes
9answers
2k views

How do I convince developers not fight code style enforcement?

I'm developer infrastructure and tools engineer. My org structure is like so (fictional names for convenience)(job level in parenthesis) Bob(3)/ Me(1)/ Alice(2)/ Sam(1)/ John(...
9
votes
5answers
1k views

How to navigate working with a development process that is not supportive of clean code?

I started working at my current job just over a year ago. When I started the code base was a complete mess. All of the code was in one file, it was not maintainable and best practices were not ...
147
votes
12answers
28k views

Is it reasonable to ask a potential employer for samples of their code and/or employee contact information, to determine if I want to work there?

I'm currently looking for a new job as a developer. There are two things that companies usually require that bother me a lot: long programming assignments and reference checks. There are plenty of ...
8
votes
6answers
1k views

How clean does the code have to be on my github

So I am nearly done with my MSc. Artifical Intelligence and starting to look into Machine Learning and Data Science positions (in Germany as this probably makes a difference.) Unfortunately some of ...
2
votes
2answers
725 views

My Manager violates IT policies and does not adhere to Standard Practices [closed]

I'm working as an offshore Senior Oracle ERP Developer with a BPO Company and have a Onshore Manager ("MM"). I've been working here for over two years now and one thing I noticed from the beginning ...
1
vote
7answers
2k views

Rejected because the code review of my skill assessment was incorrect

I applied for a programming job and one requirement is to pass a skill assessment exam. The specification for the assessment exam was: Write PHP code that displays people which are related to ...
0
votes
3answers
770 views

How to handle really bad source code? [duplicate]

I'm currently working on a project where I inherited a product somebody else made halfway-through. My job is to finish that specific project. I was told I had a free hand over what to do, so I looked ...
-1
votes
4answers
2k views

How to manage a developer who objects to our code reviews as being “rude, condescending or otherwise toxic?” [closed]

Background: As a developer what should I expect as code review feedback? What if I perceive it as rude, condescending or otherwise toxic? This developer has become so frustrated with their code ...
1
vote
5answers
953 views

Would declining a coding test disqualify me from the interview process? [duplicate]

Almost every developer interview involves a coding test. I don't really see the need for this, as I have uploaded some code on my GitHub account, all my code is publicly accessible, so if someone ...
67
votes
12answers
19k views

Code readability, conventions and should I let go

While chasing a bug, I found a few lines of code I found hard to read and improved them for readability. This change brought the code closer to what our Coding Convention says, which also states that ...
23
votes
11answers
6k views

Is it unprofessional to call code “garbage”?

Intro: I’ve been writing software for over 15 years and currently lead a team of ~10 developers with whom I conduct code reviews daily. My comments are generally direct, honest, and straight-forward. ...
28
votes
6answers
5k views

Interview programming assignment seems like free work [duplicate]

I'm applying for a company that wants me to complete a several hour coding challenge. The assignment is basically "we've got 15 templates on our site, create a 16th one". Now I've heard of companies ...
9
votes
2answers
5k views

Does anyone get fired over bad code? [closed]

Last night I was brushing up my CV which brought back memories from my past work environments. I've been in the software industry for 10 years now, from data analyst (I don't have a CS degree) - to ...
12
votes
4answers
3k views

How to deal with html / css programmer who comments out all changes he makes to CSS instead of deleting them [closed]

I am currently mentoring a co-worker who refuses to delete code. He currently works as strictly an html / css developer, but when he edits CSS, he does not delete code. He will comment out anything ...
13
votes
3answers
1k views

Can a catering assistant be required to wear a skirt as part of a company-supplied uniform?

I've worked in my catering job for 11 years. We were tuped over to our present employer 5 years ago. We wear a uniform of trousers (provided by ourselves), polo shirt and apron provided by them for ...
4
votes
1answer
745 views

Re-submitting incomplete code test after interview

I am currently interviewing for a software engineer position at a company I am really excited about. I recently had a technical interview with two engineers and have a team fit interview still to come....
0
votes
3answers
2k views

Mind went blank during interview coding test

I recently took an online coding test for a software engineering position (entry level). I am not very good at programming while a timer is counting down, but nonetheless two questions went very well. ...
122
votes
16answers
31k views

How can I deal with a coworker who doesn't particularly care about code quality?

I'm a software dev in a small team. I am the most junior member with a couple of years professional experience, but was brought to the (newly formed) team because I had the most hands-on experience ...
1
vote
4answers
1k views

Are there any known alternatives for code review?

Code review is part of the software development process, when all code written by one developer is checked by another, more senior developer, accepting it only after findings are corrected. While ...